Support non-breaking content in java #248
Merged
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojiishi
force-pushed
the
nobr-java
branch
2 times, most recently
from
2d58953 to
eb356f6
Compare
kojiishi
force-pushed
the
nobr-java
branch
2 times, most recently
from
8ea8817 to
a4e567b
Compare
This patch supports non-breaking content in Java. In Java and Python implementations, the "Skip" operation includes the skipped content to the BudouX parser, so no changes to the text for the parser is needed. This patch changes following items: 1. Add `NOBR` to the "skip" element. 2. Fix "skip" is applied only to its descendants. Before this patch, all content following "skip" elements are skipped. 3. When there's a phrase boundary right before the "skip" element, insert a break before the "skip" element.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Aug 15, 2023
This patch supports non-breaking content in Python. In Java and Python implementations, the "Skip" operation includes the skipped content to the BudouX parser, so no changes to the text for the parser is needed. This patch changes following items: 1. Changed `to_skip` to a stack of elements, rather than always reset to `False` at the end of an element. 2. When there's a phrase boundary right before the "skip" element, insert a break before the "skip" element. Note `<NOBR>` is added to `skip_nodes.json` at: google#248.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Aug 15, 2023
This patch supports non-breaking content in Python. In Java and Python implementations, the "Skip" operation includes the skipped content to the BudouX parser, so no changes to the text for the parser is needed. This patch changes following items: 1. Changed `to_skip` to a stack of elements, rather than always reset to `False` at the end of an element. 2. When there's a phrase boundary right before the "skip" element, insert a break before the "skip" element. Note `<NOBR>` is added to `skip_nodes.json` at: google#248.
tushuhei
approved these changes
Aug 17, 2023
tushuhei
pushed a commit
that referenced
this pull request
Aug 17, 2023
This patch supports non-breaking content in Python. In Java and Python implementations, the "Skip" operation includes the skipped content to the BudouX parser, so no changes to the text for the parser is needed. This patch changes following items: 1. Changed `to_skip` to a stack of elements, rather than always reset to `False` at the end of an element. 2. When there's a phrase boundary right before the "skip" element, insert a break before the "skip" element. Note `<NOBR>` is added to `skip_nodes.json` at: #248.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch supports non-breaking content in Java.
In Java and Python implementations, the "Skip" operation includes the skipped content to the BudouX parser, so no changes to the text for the parser is needed.
This patch changes following items:
NOBRto the "skip" element.