Fix unpaired close tags and self-closing tags #360
Merged
+58
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google#251 assumed that all tags are closed properly. This assumption doesn't stand for cases like: 1. Self-closing tags such as `<img>` don't have corresponding close tags. 2. Unpaired close tags are still valid HTML. This patch supports these cases by assuming all open tags that doesn't nest correctly or that doesn't close are automatically closed. This isn't the full HTML "adoption agency algorithm", but it should be good enough for the needs of BudouX. Fixes google#355
tushuhei
previously approved these changes
Nov 10, 2023
tests/test_html_processor.py
Outdated
| resolver = html_processor.HTMLChunkResolver(['abxyabc', 'def'], '<wbr>') | ||
| resolver.feed(input) | ||
| self.assertEqual(resolver.output, expected, | ||
| 'WBR tags should not be inserted if NOBR.') |
Member
There was a problem hiding this comment.
Could you elaborate this test message by mentioning the IMG tag?
Collaborator
Author
There was a problem hiding this comment.
Good catch, thanks, done.
Member
|
@kojiishi I left a small comment actually. PTAL. |
tushuhei
reviewed
Nov 10, 2023
Member
tushuhei
left a comment
tushuhei
left a comment
There was a problem hiding this comment.
A nit request about the test message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#251 assumed that all tags are closed properly.
This assumption doesn't stand for cases like:
<img>don't have corresponding close tags.This patch supports these cases by assuming all open tags that doesn't nest correctly or that doesn't close are automatically closed.
This isn't the full HTML "adoption agency algorithm", but it should be good enough for the needs of BudouX.
Fixes #355