Skip to content

Add granularity option to prepare_knbc.py #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tushuhei merged 2 commits into from
Dec 18, 2023
Merged

Add granularity option to prepare_knbc.py #417

tushuhei merged 2 commits into from
Dec 18, 2023

Conversation

@tushuhei
Copy link
Member

@tushuhei tushuhei commented Dec 18, 2023

Now users can control the granularity of chunks to be generated from the KNBC corpus with the granularity arg.

python scripts/prepare_knbc.py KNBC_v1.0_090925_utf8 --granularity=phrase
python scripts/prepare_knbc.py KNBC_v1.0_090925_utf8 --granularity=tag
python scripts/prepare_knbc.py KNBC_v1.0_090925_utf8 --granularity=word

@tushuhei tushuhei requested a review from kojiishi December 18, 2023 06:31
kojiishi
kojiishi approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@tushuhei tushuhei merged commit 09e26f8 into main Dec 18, 2023
@tushuhei tushuhei deleted the ja-word branch December 18, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kojiishi kojiishi kojiishi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tushuhei @kojiishi