WIP: Fix cAdvisor running in a container on RHEL platforms#1474
WIP: Fix cAdvisor running in a container on RHEL platforms#1474derekwaynecarr wants to merge 2 commits into
Conversation
|
FYI: @smarterclayton @ncdc @pmorie @mrunalp The first commit is temporary carry for opencontainers/runc#1049. Once that merges, I can just drop the carry and update with a vendor dependency being updated. I am testing this now on RHEL in container to validate it works ;-) |
|
@derekwaynecarr Sounds good. Let me know if you run into any issues. |
derekwaynecarr
force-pushed
the
cadvisor-rhel-container-fix
branch
from
9fb061c to
e3ee9a0
Compare
derekwaynecarr
force-pushed
the
cadvisor-rhel-container-fix
branch
from
e3ee9a0 to
c7acc62
Compare
|
OK -- confirmed on RHEL7 in container that this works for me. Will update the PR when @mrunalp code merges. |
derekwaynecarr
force-pushed
the
cadvisor-rhel-container-fix
branch
from
c7acc62 to
9d71675
Compare
|
seems like it might be good to have 'opencontainers/runc#1049' in the commit message for the carry |
|
@pmorie -- the carry is intended to be replaced before this PR merges. I was just holding it there for testing purposes. |
|
@derekwaynecarr runc PR is merged now so you can pick it up. |
|
requisite runc pr has merged, will send a pr to update vendor library and then drop the first commit here. |
|
Closing this in favor of #1476 |
4 participants
Fixes #1461