Skip to content

cgroup: initial support for cgroups v2#2309

Merged
dashpole merged 2 commits into
google:masterfrom
giuseppe:libcontainer-cgroupv2
Sep 9, 2019
Merged

cgroup: initial support for cgroups v2#2309
dashpole merged 2 commits into
google:masterfrom
giuseppe:libcontainer-cgroupv2

Conversation

@giuseppe
Copy link
Copy Markdown
Contributor

@giuseppe giuseppe commented Sep 6, 2019

add some initial support for cgroups v2. Not all the stats supported on cgroups v1 are supported, e.g. it is not possible to read percpu usage.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@k8s-ci-robot
Copy link
Copy Markdown
Collaborator

Hi @giuseppe. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@giuseppe giuseppe changed the title cgroup: initial support for cgroups v2 [RFC] cgroup: initial support for cgroups v2 Sep 6, 2019
@dashpole
Copy link
Copy Markdown
Collaborator

dashpole commented Sep 6, 2019

/ok-to-test

Comment thread container/common/helpers.go Outdated
Comment thread container/common/helpers.go Outdated
Comment thread manager/manager.go Outdated
@giuseppe giuseppe force-pushed the libcontainer-cgroupv2 branch from 81e493b to a537e44 Compare September 6, 2019 19:19
add some initial support for cgroups v2.  Not all the stats
supported on cgroups v1 are supported, e.g. it is not possible to read
percpu usage.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the libcontainer-cgroupv2 branch from a537e44 to 60f064e Compare September 6, 2019 19:26
Copy link
Copy Markdown
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dashpole dashpole merged commit b253b65 into google:master Sep 9, 2019
@giuseppe giuseppe changed the title [RFC] cgroup: initial support for cgroups v2 cgroup: initial support for cgroups v2 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants