This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Robustify fork server launching & problem detection, part 2#537
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Robustify fork server launching & problem detection, part 2#537copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This change addresses the problem (2) from the bug: 2. Both the engine and the fork server attempt to open the comms pipes in the blocking mode. That requires that both sides successfully arrive at the point where they attempt opening. However, a misbehaving or miscompiled fuzz target may exit and thus terminate the fork server early, leaving the engine perpetually waiting at an `open()` call. This and the previous change fix the symptom (3): 3. As a result of (1) and (2), execution problems aren't properly detected: a bad target may silently fail without opening the pipes and the engine blocks at the open() call forever, waiting for the absent fork server to open() its side of the pipes. PiperOrigin-RevId: 516385635
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robustify fork server launching & problem detection, part 2
This change addresses the problem (2) from the bug:
open()call.This and the previous change fix the symptom (3):