Allow external LLVM and Clang folders.#374
Merged
alan-baker merged 1 commit intogoogle:masterfrom May 29, 2019
dj2:build
Merged
Allow external LLVM and Clang folders.#374alan-baker merged 1 commit intogoogle:masterfrom dj2:build
alan-baker merged 1 commit intogoogle:masterfrom
dj2:build
Conversation
This CL updates the build files to allow setting the CLSPV_LLVM_SOURCE_DIR and CLSPV_CLANG_SOURCE_DIR without specifying an EXTERNAL_LLVM. Because those directories maybe outside the clspv/ source tree we have to provide the build directory when calling add_subdirectory.
alan-baker
reviewed
May 29, 2019
|
|
||
|
|
||
| # Then pull in LLVM for building. | ||
| add_subdirectory(${CLSPV_LLVM_SOURCE_DIR} EXCLUDE_FROM_ALL) |
Collaborator
There was a problem hiding this comment.
Why is this necessary? It seems strange to add a directory in the build tree.
Contributor
Author
There was a problem hiding this comment.
In my case I checkout third_party/clspv, third_party/clspv-llvm and third_party/clspv-clang. You can't add a subdirectory which is outside your subtree without providing the build directory. So, to keep things the same I set the build directory to what it would have been if it was in-subtree.
alan-baker
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL updates the build files to allow setting the
CLSPV_LLVM_SOURCE_DIR and CLSPV_CLANG_SOURCE_DIR without specifying an
EXTERNAL_LLVM.
Because those directories maybe outside the clspv/ source tree we have
to provide the build directory when calling add_subdirectory.