Test improvements for SSLEngine wrap preconditions #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing preconditions which should pass, reset the source data each time and check that wrap succeeds end to end. Also make source data read-only to ensure it's never mofidied.
juergw
reviewed
Nov 11, 2025
common/src/test/java/org/conscrypt/javax/net/ssl/SSLEngineTest.java
Outdated
Show resolved
Hide resolved
juergw
reviewed
Nov 17, 2025
common/src/test/java/org/conscrypt/javax/net/ssl/SSLEngineTest.java
Outdated
Show resolved
Hide resolved
prbprbprb
changed the title
Contributor
Author
|
Apologies for the slow turnaround, hopefully this PR is now more acceptable. |
juergw
approved these changes
Nov 24, 2025
common/src/test/java/org/conscrypt/javax/net/ssl/SSLEngineTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.