Updating Docsy moves navbar to the left (wrong) side

[mhansen]

Hi there, I just updated Graphviz to the latest Docsy with git submodule update --remote, now the table of contents is on the wrong side of the screen:

I suspect this is related to #554 merged 2 days ago, because that commit changed the navbar HTML layout from a <div> tag to an <aside> tag: https://github.com/google/docsy/pull/554/files#diff-4a7bcb5855bcc928f61527aba2cb16f957266b13ab51553e46016c82ac8c4dd2R16. But I haven't looked into it further than that yet.

[mhansen]

If you'd like to reproduce, git clone https://gitlab.com/graphviz/graphviz.gitlab.io and run git submodule update --remote then hugo serve

[mhansen]

I just confirmed that #554 is the cause: I checked out f82dd5e (immediately before #554 was merged) and the navbar is on the correct side.

[mhansen]

@narrenfrei FYI -- perhaps this has the same cause as the test data getting into docsy.dev?

[LisaFC]

Oh yeah, that shouldn't do that - let me take a look. I don't think it's anything to do with the test data, that was just data that got merged in in error.

[LisaFC]

Though it is very weird, as if I look at the deploy preview for #554 (https://deploy-preview-554--docsydocs.netlify.app/docs/) the table of contents is in the right place, so I'm not sure why it's shifted left for you. Can you tell me what browser you're using?

We'll try and get the test data removed ASAP as well.

[mhansen]

Yeah, maybe it’s something about my layout. I’m using macOS Google Chrome.

…

On Mon, 14 Jun 2021 at 19:55, LisaFC ***@***.***> wrote: Though it is very weird, as if I look at the deploy preview for #554 <#554> ( https://deploy-preview-554--docsydocs.netlify.app/docs/) the table of contents is in the right place, so I'm not sure why it's shifted left for you. Can you tell me what browser you're using? We'll try and get the test data removed ASAP as well. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZYOP4F26WWVWG2YJ5V3LTSXGXHANCNFSM46ULWQLA> .

[narrenfrei]

Maybe it's browser specific. But I have to ask: do you have any project specific Stylesheets?

[mhansen]

The only extra css we add is prism.css for syntax highlighting.

…

On Mon, 14 Jun 2021 at 19:59, Franz Steininger ***@***.***> wrote: Maybe it's browser specific. But I have to ask: do you have any project specific Stylesheets? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZYOK74IZIT6ISPGOJVA3TSXHJBANCNFSM46ULWQLA> .

[narrenfrei]

@mhansen
Have you tried to update all sub modules as described in https://www.docsy.dev/docs/getting-started/#using-the-command-line by git submodule update --init --recursive?

Because after running your commands above ...

git clone https://gitlab.com/graphviz/graphviz.gitlab.io
git submodule update --remote
hugo server

... I've got some error message. But after running git submodule update --init --recursive Hugo could build the site and the TOC was shown on the right position.

[mhansen]

I'm able to build the site. Is the error message you get "WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false."? I think `git submodule update --init --recursive` undoes the `git submodule update --remote`, reverting back to the previously-commited version of docsy.

…

On Tue, 15 Jun 2021 at 06:57, Franz Steininger ***@***.***> wrote: @mhansen <https://github.com/mhansen> Have you tried to update all sub modules as described in https://www.docsy.dev/docs/getting-started/#using-the-command-line by git submodule update --init --recursive? Because after running your commands above ... git clone https://gitlab.com/graphviz/graphviz.gitlab.io git submodule update --remote hugo server ... I've got some error message. But after running git submodule update --init --recursive Hugo could build the site and the TOC was shown on the right position. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#590 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZYOLTR4TZMHETR4EQK2DTSZULXANCNFSM46ULWQLA> .

[mhansen]

Try this, I think I skipped a step: git clone https://gitlab.com/graphviz/graphviz.gitlab.io git submodule update --init --recursive git submodule update --remote hugo server

…

On Tue, 15 Jun 2021 at 08:58, Mark Hansen ***@***.***> wrote: I'm able to build the site. Is the error message you get "WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false."? I think `git submodule update --init --recursive` undoes the `git submodule update --remote`, reverting back to the previously-commited version of docsy. On Tue, 15 Jun 2021 at 06:57, Franz Steininger ***@***.***> wrote: > @mhansen <https://github.com/mhansen> > Have you tried to update all sub modules as described in > https://www.docsy.dev/docs/getting-started/#using-the-command-line by git > submodule update --init --recursive? > > Because after running your commands above ... > > git clone https://gitlab.com/graphviz/graphviz.gitlab.io > git submodule update --remote > hugo server > > ... I've got some error message. But after running git submodule update > --init --recursive Hugo could build the site and the TOC was shown on > the right position. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#590 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAZYOLTR4TZMHETR4EQK2DTSZULXANCNFSM46ULWQLA> > . >

[narrenfrei]

After this steps I get also the right positioned TOC.
Tested on MAC with Safari, Chrome and Firefox

[LisaFC]

Excellent! Can I close the issue?

[mhansen]

Ah, sorry for the hassle. I just reran my own repro steps in a fresh git repo and couldn't reproduce. Sorry for wasting your time; I'll close this for now and update if I figure out how I screwed up my git repository. Probably ran some bad submodule command.