Rendering with offlineSearch fails: offline-search-index.json:750: comment ends before closing delimiter

[marians]

With hugo 0.88.1 and the latest Docsy from master I get the following error when rendering a site with offlineSearch = true:

Error: Error building site: EXECUTE-AS-TEMPLATE: failed to transform "offline-search-index.json" (application/json): failed to parse Resource "offline-search-index.json" as Template:: template: offline-search-index.json:750: comment ends before closing delimiter

The file mentioned is https://github.com/google/docsy/blob/ea64eddd6be4c754cb207e79ebd6a6ca05ea4f08/assets/json/offline-search-index.json

By trial and error I have narrowed down the problem to the rendering of the "body" attribute. When I remove the "body" (.Plain | htmlUnescape) part from the template, the error disappears and the file is generated just fine.

So I'm guessing the escaping of the body field isn't happening as it should be.

Unfortunately the content is not public. Anything I can do to narrow down the problem?

[LukeTimeWalker]

We get a similar error when we try to build our hugo project using the latest docsy theme.

Error: Error building site: EXECUTE-AS-TEMPLATE: failed to transform "offline-search-index.json" (application/json): failed to parse Resource "offline-search-index.json" as Template:: template: offline-search-index.json:453: function "ansible_env" not defined

As far as I know, the problem is because our offline-search-index.json contains two curly braces. Through the resources.ExecuteAsTemplate pipe, hugo tries to render the JSON file with templates (which are also indicated by two curly braces in hugo).

docsy/layouts/partials/search-input.html

Line 4 in 170cdd9

{{ $offlineSearchIndex := resources.Get "json/offline-search-index.json" | resources.ExecuteAsTemplate "offline-search-index.json" . }}

In my opinion there is no reason to 'render' the search index with templates.

Without the ExecuteAsTemplate Pipe the project can be build without any errors.

[LisaFC]

@tekezo do you want to take a look? I can take a look as well tomorrow.

[tekezo]

I have confirmed the issue in my environment.
(This issue only happens when {{ is included in contents.)

It seems the problem is caused by Hugo side, Hugo evaluates the contents of variable as template at accessing variable by Scratch.Get, it should be fixed in Hugo.

I'll continue to investigate the right way to how to fix this.

[tekezo]

I fixed docsy template to avoid this issue at #710 .

@LisaFC Could you review and merge the PR?

[LisaFC]

Fixed in #710

[marians]

After updating to version e4bb26b im am now getting a slightly different error:

ERROR 2021/10/05 07:44:22 EXECUTE-AS-TEMPLATE: failed to transform "json/offline-search-index.json" (application/json): failed to parse Resource "json/offline-search-index.json" as Template:: template: json/offline-search-index.json:5: unclosed action

[marians]

Please ignore the above comment. I can't reproduce that error any more in a fresh docker container.