Scripts: get bootstrap.js and popper.js at build time#1187
Merged
chalin merged 1 commit intogoogle:mainfrom Aug 19, 2022
Merged
Scripts: get bootstrap.js and popper.js at build time#1187chalin merged 1 commit intogoogle:mainfrom
chalin merged 1 commit intogoogle:mainfrom
Conversation
Collaborator
Author
|
As is mentioned in Components from the Bootstrap docs:
Tooltips are still working (they're used in the footer): |
Collaborator
Author
|
Thanks for the review. Merged so that I can more easily experiment with: |
Contributor
|
This commit broke docsy module installations. We need to add a mount so that bootstrap.js becomes available with module installations (see PR #1216). |
fekete-robert
pushed a commit
to fekete-robert/docsy
that referenced
this pull request
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.