Skip to content

Scripts: get bootstrap.js and popper.js at build time#1187

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-bs-from-package-2022-08-18
Aug 19, 2022
Merged

Scripts: get bootstrap.js and popper.js at build time#1187
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-bs-from-package-2022-08-18

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Aug 18, 2022

@chalin chalin requested review from LisaFC, deining and geriom August 18, 2022 11:33
@chalin
Copy link
Copy Markdown
Collaborator Author

chalin commented Aug 18, 2022

As is mentioned in Components from the Bootstrap docs:

Tooltips and popovers [are used] for displaying and positioning (also requires Popper)

Tooltips are still working (they're used in the footer):

image

Copy link
Copy Markdown
Collaborator

@LisaFC LisaFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chalin chalin merged commit 10fae88 into google:main Aug 19, 2022
@chalin chalin deleted the chalin-im-bs-from-package-2022-08-18 branch August 19, 2022 00:18
@chalin
Copy link
Copy Markdown
Collaborator Author

chalin commented Aug 19, 2022

Thanks for the review. Merged so that I can more easily experiment with:

@chalin chalin added dependencies Pull requests that update a dependency file bootstrap labels Aug 19, 2022
@deining
Copy link
Copy Markdown
Contributor

deining commented Sep 2, 2022

This commit broke docsy module installations. We need to add a mount so that bootstrap.js becomes available with module installations (see PR #1216).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bootstrap dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants