Upgrade font awesome to the latest version#121
Merged
LisaFC merged 3 commits intogoogle:masterfrom Aug 15, 2019
Fox32:master
Merged
Upgrade font awesome to the latest version#121LisaFC merged 3 commits intogoogle:masterfrom Fox32:master
LisaFC merged 3 commits intogoogle:masterfrom
Fox32:master
Conversation
Collaborator
|
Thanks for this! |
Collaborator
|
@Fox32 - FYI, the following PR proposed that we drop the webfonts. WDYT? Also related is: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There where some breaking changes in the usage of FontAwesome, so I had to modify the scss. Sadly we have to copy the font files into the theme.
The documentation wants me to override
td-enable-google-fontsif I want to use a custom font, but is still loading it as overriding isn't possible. This is also fixed with this PR.I also added crosssorigin anonymous to the script tag, otherwise it's not possible to let Netlify put it on an external CDN.