Skip to content

keep height of persistent language tabs constant #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
titusfortner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

keep height of persistent language tabs constant #1227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions static/js/tabpane-persist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,28 @@ const _tdStoragePersistKey = (tabKey) =>

const _tdSupportsLocalStorage = () => typeof Storage !== 'undefined';

function adjustTabContentHeights() {
const contentTabs = document.querySelectorAll('.tab-content');

// Loop through each tabpane
contentTabs.forEach(contentTab => {
let maxHeight = 0;
const tabPanes = contentTab.querySelectorAll('.tab-pane');

// Loop through each tab in the tabpanes list to find max
tabPanes.forEach(tab => {
tab.style.display = 'block';
maxHeight = Math.max(maxHeight, tab.clientHeight);
tab.style.display = '';
});

// Loop through each tab in the tabpanes list to set height
tabPanes.forEach(tab => {
tab.style.height = maxHeight + 'px';
});
});
}

// Helpers

function tdPersistKey(key, value) {
Expand Down Expand Up @@ -93,6 +115,9 @@ function tdGetAndActivatePersistedTabs(tabs) {
tdActivateTabsWithKey(key);
});

// Adjust tab content heights
adjustTabContentHeights();

return key_ageList;
}

Expand Down