Apply styling to all elements in td-content#1255
Merged
geriom merged 1 commit intogoogle:mainfrom Oct 14, 2022
Merged
Conversation
anoadragon453
added a commit
to matrix-org/matrix-spec
that referenced
this pull request
Oct 27, 2022
Otherwise table-layout has no effect. I'm not sure why this broke, possibly google/docsy#1255.
|
Hello! This change caused I'm not sure if this was intended behaviour, but leaving a breadcrumb here if anyone would like to investigate on the docsy side :) |
Collaborator
|
@anoadragon453 - thank you for the in-depth analysis and feedback. Given that Docsy assumes that tables are responsive by default, yes this was intended. We're all looking forward to the Bootstrap upgrade. You may be right that after the upgrade your style change will be unnecessary. I'll add a note to the Bootstrap-upgrade issue as a reminder for us to check (added in opening comment). |
This was referenced Feb 17, 2023
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based off of PR 1017, as I could not get clarity on signing the Google CLA from my corporate GH account. I hope the contribution is still useful, my apologies for the overly long wait time.
As stated in #883 (and the original PR), tables were not being styled properly in
<details><summary>blocks. I found the same issue to affect tables nested in list elements.Removing
>from the table entry enables proper styling to be applied to any table element that's a child of td-content.As per the request in the original PR comments, I also removed the
>selector fromblockquote,ul liandol lielements.