Skip to content

tabpane: use data- attribute instead of class name#1607

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-tabpane-data-attr-2023-07-05
Jul 5, 2023
Merged

tabpane: use data- attribute instead of class name#1607
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-tabpane-data-attr-2023-07-05

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Jul 5, 2023

  • Contributes to Tabpane shortcode fixes and enhancements (July) #1605
  • Switches to attaching the persistence key to tab HTML elements as a data- attribute rather than a CSS class name
  • Preserves converting the persistence key to lowercase, though now there's no longer a new to replace any characters
  • Other improvements to the JS to make it more robust

Copy link
Copy Markdown
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit 397c5d4 into google:main Jul 5, 2023
@chalin chalin deleted the chalin-im-tabpane-data-attr-2023-07-05 branch July 5, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants