Skip to content

Fix whitespace cleanup syntax issue#1626

Merged
chalin merged 1 commit intogoogle:mainfrom
sevein:dev/fix-template-syntax-issue
Jul 27, 2023
Merged

Fix whitespace cleanup syntax issue#1626
chalin merged 1 commit intogoogle:mainfrom
sevein:dev/fix-template-syntax-issue

Conversation

@sevein
Copy link
Copy Markdown
Contributor

@sevein sevein commented Jul 20, 2023

I believe this was introduced in bf65c18.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jul 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sevein sevein force-pushed the dev/fix-template-syntax-issue branch from 09faf07 to 2fc333e Compare July 20, 2023 15:14
Copy link
Copy Markdown
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin force-pushed the dev/fix-template-syntax-issue branch from 2fc333e to 941a910 Compare July 27, 2023 17:22
Copy link
Copy Markdown
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chalin
Copy link
Copy Markdown
Collaborator

chalin commented Jul 27, 2023

I believe this was introduced in bf65c18.

Yes, thanks for catching that.

@chalin chalin merged commit 0b20474 into google:main Jul 27, 2023
@chalin
Copy link
Copy Markdown
Collaborator

chalin commented Jul 27, 2023

I'm surprised that this didn't show up as an issue under #1604. /cc @theletterf

@theletterf
Copy link
Copy Markdown
Contributor

Hm, that's weird, yeah.

@sevein sevein deleted the dev/fix-template-syntax-issue branch August 2, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants