Skip to content

[UG] Refer to Bootstrap 5 doc pages and files#1844

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-no-more-bs-4-2024-02-07
Feb 8, 2024
Merged

[UG] Refer to Bootstrap 5 doc pages and files#1844
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-no-more-bs-4-2024-02-07

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Feb 7, 2024

Preview: https://deploy-preview-1844--docsydocs.netlify.app/docs/adding-content/lookandfeel/

@chalin chalin added the user guide Improvements to user guide label Feb 7, 2024
This was referenced Feb 7, 2024
@chalin chalin added this to the 24Q1 milestone Feb 7, 2024
[_variables]: https://github.com/google/docsy/blob/main/assets/scss/_variables.scss
[v4-dev/scss/_variables.scss]: https://github.com/twbs/bootstrap/blob/v4-dev/scss/_variables.scss
[Docsy uses Bootstrap 5]: /blog/2023/bootstrap-5-migration/
[Variable defaults]: https://getbootstrap.com/docs/4.1/getting-started/theming/#variable-defaults
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! I was clearly zip'n too quickly through this one. I'll fix it soon.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin chalin force-pushed the chalin-im-no-more-bs-4-2024-02-07 branch from 5ca9bb6 to 7b662aa Compare February 8, 2024 22:50
@chalin chalin force-pushed the chalin-im-no-more-bs-4-2024-02-07 branch from 7b662aa to 580aa75 Compare February 8, 2024 22:54
@chalin chalin merged commit 612f0c5 into google:main Feb 8, 2024
@chalin chalin deleted the chalin-im-no-more-bs-4-2024-02-07 branch February 8, 2024 22:58
@chalin
Copy link
Copy Markdown
Collaborator Author

chalin commented Feb 8, 2024

@LisaFC - comments are still welcome on this PR.

@LisaFC
Copy link
Copy Markdown
Collaborator

LisaFC commented Feb 9, 2024

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user guide Improvements to user guide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants