Skip to content

Drop _internal prefix from template paths #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalin merged 3 commits into from
May 22, 2025
Merged

Drop _internal prefix from template paths #2250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee3558
Drop `_internal` prefix from template paths
chalin May 16, 2025
ff7e8c3
Fix production failures
chalin May 16, 2025
b0db0ac
Update refcache.json
chalin May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions layouts/_partials/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{/* cSpell:ignore docsearch opengraph outputformat */ -}}
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
{{ range .AlternativeOutputFormats -}}
Expand All @@ -21,9 +22,9 @@
{{ end -}}
</title>
<meta name="description" content="{{ partial "page-description.html" . }}">
{{ template "_internal/opengraph.html" . -}}
{{ template "_internal/schema.html" . -}}
{{ template "_internal/twitter_cards.html" . -}}
{{ partial "opengraph.html" . -}}
{{ partial "schema.html" . -}}
{{ partial "twitter_cards.html" . -}}
{{ partialCached "head-css.html" . "head-css-cache-key" -}}
<script
src="https://code.jquery.com/jquery-3.7.1.min.js"
Expand All @@ -46,7 +47,7 @@

{{/* To comply with GDPR, cookie consent scripts places in head-end must execute before Google Analytics is enabled */ -}}
{{ if hugo.IsProduction -}}
{{ template "_internal/google_analytics.html" . -}}
{{ partial "google_analytics.html" . -}}
{{ end -}}

{{ define "algolia/head" -}}
Expand Down
2 changes: 1 addition & 1 deletion layouts/blog/list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ <h5 class="mt-0 mb-1"><a href="{{ .RelPermalink }}">{{ .Title }}</a></h5>
{{ end -}}
</div>
<div class="td-blog-posts__pagination">
{{ template "_internal/pagination.html" . -}}
{{ partial "pagination.html" . -}}
</div>
{{- end -}}
{{ end -}}
8 changes: 4 additions & 4 deletions userguide/content/en/docs/adding-content/feedback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ weight: 8
## Adding Analytics

The Docsy theme builds upon [Hugo's support for Google Analytics][hugo-ga],
which Hugo provides through [internal templates][]. Once you set up analytics as
which Hugo provides through [embedded templates][]. Once you set up analytics as
described below, usage information for your site (such as page views) is sent to
your [Google Analytics][] account.

Expand Down Expand Up @@ -301,12 +301,12 @@ partial. For details, see
[Customizing templates](lookandfeel/#customizing-templates).

[Configure Google Analytics]:
https://gohugo.io/templates/internal/#configure-google-analytics
https://gohugo.io/templates/embedded/#configure-google-analytics
[ga4-intro]: https://support.google.com/analytics/answer/1042508
[Google Analytics]: https://analytics.google.com/analytics/web/
[gtag.js]: https://support.google.com/analytics/answer/10220869
[hugo-ga]: https://gohugo.io/templates/internal/#google-analytics
[internal templates]: https://gohugo.io/templates/internal/
[hugo-ga]: https://gohugo.io/templates/embedded/#google-analytics
[embedded templates]: https://gohugo.io/templates/embedded/
[page-description.html]:
https://github.com/google/docsy/blob/main/layouts/_partials/page-description.html
[site `params`]: https://gohugo.io/variables/site/#the-siteparams-variable
Expand Down
12 changes: 12 additions & 0 deletions userguide/static/refcache.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1847,6 +1847,18 @@
"StatusCode": 206,
"LastSeen": "2025-05-16T09:20:37.548164-04:00"
},
"https://gohugo.io/templates/embedded/": {
"StatusCode": 206,
"LastSeen": "2025-05-16T10:33:25.556387-04:00"
},
"https://gohugo.io/templates/embedded/#configure-google-analytics": {
"StatusCode": 206,
"LastSeen": "2025-05-16T10:33:25.984266-04:00"
},
"https://gohugo.io/templates/embedded/#google-analytics": {
"StatusCode": 206,
"LastSeen": "2025-05-16T10:33:25.360519-04:00"
},
"https://gohugo.io/templates/internal/": {
"StatusCode": 206,
"LastSeen": "2025-05-16T09:20:34.993115-04:00"
Expand Down