Move new content-after-header hook into partials folder, add UG entry#2256
Merged
chalin merged 3 commits intogoogle:mainfrom May 22, 2025
Merged
Conversation
11 tasks
chalin
changed the title
chalin
force-pushed
the
chalin-rw-im-td-content-after-2025-05-22
branch
from
309bde6 to
1145c18
Compare
LisaFC
reviewed
May 23, 2025
|
|
||
| To have a banner, or other similar content, appear at the top of the pages in a | ||
| section, add the content to the [td/content-after-header.html] partial. It will | ||
| appear inside the `div.td-content`, after `</header>`, just before `.Content` is |
Collaborator
There was a problem hiding this comment.
My only suggested change here is to take out one of the commas as it's a bit hard to read, so:
It will appear inside the div.td-content after </header>, just before .Content is
rendered.
chalin
added a commit
to chalin/docsy
that referenced
this pull request
May 23, 2025
Partial revert of google#2256.
fekete-robert
pushed a commit
to fekete-robert/docsy
that referenced
this pull request
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
layouts/td-content-after-header.htmlinto the_partialsfolder since the hook is actually a partial just like the other hooks._partials/tdand not_partials/td/hooks? Because everything undertdis a hook atm. Note that use oftdis in support of Namespace Docsy SCSS and other files #1654Preview: https://deploy-preview-2256--docsydocs.netlify.app/docs/adding-content/lookandfeel/#before-page-content