Skip to content

Always show lang menu in navbar#2303

Merged
chalin merged 6 commits intogoogle:mainfrom
chalin:chalin-im-lang-menu-2025-08-02
Aug 5, 2025
Merged

Always show lang menu in navbar#2303
chalin merged 6 commits intogoogle:mainfrom
chalin:chalin-im-lang-menu-2025-08-02

Conversation

@chalin
Copy link
Copy Markdown
Collaborator

@chalin chalin commented Aug 2, 2025

  • Fixes Language dropdown menu hidden in narrow displays #2035: the language menu will always be shown in the navbar for multilingual sites.
  • Fixes [UX] Leave language dropdown menu in the top nav, use icon for title #2132: added the globe icon as suggested.
    • On mobile, uses language code as menu title
  • Adds a placeholder language so that multilingual features can be demonstrated. Ensure that those pages are marked as noindex.
  • Fixes placement issues with light-dark dropdown
  • Hides the language menu from the sidebar by default. Legacy behavior can be recovered via config. See CHANGELOG for details.
  • Removes overflow-hidden for the navbar on mobile. That'll not look super pretty, but it'll make obvious a feature that most users don't know exist: that the navbar can scroll! Feedback is welcome.

Preview: https://deploy-preview-2303--docsydocs.netlify.app/docs/

Screenshots

Mobile / narrow

Closed Open
image image

Tablet

image

Desktop

image

/cc @vitorvasc @theletterf @svrnm @tiffany76 - PTAL

@chalin chalin added UX design/style Front-end site design / styling labels Aug 2, 2025
@chalin chalin force-pushed the chalin-im-lang-menu-2025-08-02 branch from 540f422 to 9b82351 Compare August 2, 2025 21:42
Copy link
Copy Markdown

@vitorvasc vitorvasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice catch on removing the overflow-hidden 😄

@LisaFC
Copy link
Copy Markdown
Collaborator

LisaFC commented Aug 5, 2025

Oh that's excellent. I think the scrolly navbar on mobile works well.

@LisaFC LisaFC self-assigned this Aug 5, 2025
@chalin chalin merged commit aa8a701 into google:main Aug 5, 2025
11 checks passed
@chalin chalin deleted the chalin-im-lang-menu-2025-08-02 branch August 5, 2025 13:25
WCheng111 pushed a commit to WCheng111/Dali-TDLI-web that referenced this pull request Sep 12, 2025
@chalin chalin added this to the 25Q3 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design/style Front-end site design / styling UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX] Leave language dropdown menu in the top nav, use icon for title Language dropdown menu hidden in narrow displays

3 participants