Fix a offline search issue that escaped HTML entities is shown#275
Merged
LisaFC merged 5 commits intogoogle:masterfrom Jun 15, 2020
Merged
Fix a offline search issue that escaped HTML entities is shown#275LisaFC merged 5 commits intogoogle:masterfrom
LisaFC merged 5 commits intogoogle:masterfrom
Conversation
medyagh
reviewed
May 24, 2020
Member
medyagh
left a comment
There was a problem hiding this comment.
thank you for adding this feature, does it would it paginate if the results are more than the screen? if not it still a great PR ! thank you
Contributor
Author
|
@medyagh I'm not planned to add pagination because lunr.js always returns entire results. |
Member
sounds good, I look forward for this PR to be merged ! I would like to use this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a offline search issue that escaped HTML entities is shown as follows, and adds two configuration options.
Fix an issue
Before:

After:

Add configuration options
offlineSearchSummaryLengthwhich changes the summary length.offlineSearchMaxResultswhich changes the maximum result count.