Forces sidebar search to hide on desktop but show on mobile, when enabled#297
Merged
LisaFC merged 3 commits intogoogle:masterfrom Jul 1, 2020
mgibson323:master
Merged
Forces sidebar search to hide on desktop but show on mobile, when enabled#297LisaFC merged 3 commits intogoogle:masterfrom mgibson323:master
LisaFC merged 3 commits intogoogle:masterfrom
mgibson323:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Collaborator
|
This looks really helpful, I'll take a proper look at how you've implemented it before I comment/merge but it seems like it should really help our mobile users. |
Collaborator
|
Also should fix #211 |
LisaFC
requested changes
Jun 29, 2020
Collaborator
|
Thanks!! |
This was referenced Aug 17, 2021
This was referenced Sep 15, 2021
This was referenced Nov 27, 2023
This was referenced May 14, 2024
Challenge-Cyber
pushed a commit
to Challenge-Cyber/sok
that referenced
this pull request
Sep 30, 2025
Challenge-Cyber
pushed a commit
to Challenge-Cyber/sok
that referenced
this pull request
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using the Docsy theme on a project for work. Our goal was to have search enabled but only have 1 search box displayed at a time. This can be accomplished by hiding the sidebar search in
config.toml, but this also hides it for mobile users. This creates a problem since the search box on the main menu at the top of the page is hidden on mobile.To fix this, I modified
assets/scss/_sidebar-tree.scssandlayouts/partials/sidebar-tree.html. The changes are trivial, but now the sidebar search box is hidden on desktop and shows on mobile - when it's enabled inconfig.toml.There may be a better or more elegant way to do this so please feel free to implement it in whatever way makes sense for the project.
Thanks!