Foldable sidebar (Issue #342)#518
Foldable sidebar (Issue #342)#518LisaFC merged 26 commits intogoogle:masterfrom narrenfrei:foldable-sidebar
Conversation
…into foldable-sidebar
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@LisaFC After bringing my dev branch up to date with the current master from Docsy, the cla/google bot says: "CLAs are signed, but unable to verify author consent". I don't really know why? Do you (or anybody else) know why, and more important how to solve it? |
|
FYI: the PR also includes a few minor changes, as the sidebar menu was a bit wasteful with space (every UL tag got a padding right - also the nested ones!). |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
From my side this PR would be ready (except some code cleaning and polishing). Would be grateful for feedback or if someone would find time to test: |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@emckean, do you know what's going on with the Google CLA bot? I'll take some time later today/tomorrow to have a look at the actual functionality in the PR! Thanks for this! |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
As the PR is ready from my side, I've removed the WIP in the label. When merging you should exclude: config.toml |
|
Would be great, if we could get this merged soon. |
|
@LisaFC Shall I remove my test content from the PR, that you can simply merge it? |
|
I think I resolved the "merge conflicts" that were blocking this PR (do take a look to validate) but I'll let @LisaFC handle the final review/merging of the content. |
|
Looks good! |
As already discussed in #342 this is my suggestion for a foldable sidebar menu. It should also work with a cached sidebar menu. I've also added some general CSS tweaks for the sidebar menu.
Here you can find a preview (that also have set icons in the sidebar menu partly): https://deploy-preview-518--docsydocs.netlify.app/docs/
I've also added a short how to: https://deploy-preview-518--docsydocs.netlify.app/docs/adding-content/navigation/#section-menu
This PR is based on the PR #511 (manual extern links) and should merged after it.