Skip to content

Foldable sidebar (Issue #342)#518

Merged
LisaFC merged 26 commits intogoogle:masterfrom
narrenfrei:foldable-sidebar
Jun 14, 2021
Merged

Foldable sidebar (Issue #342)#518
LisaFC merged 26 commits intogoogle:masterfrom
narrenfrei:foldable-sidebar

Conversation

@narrenfrei
Copy link
Copy Markdown
Contributor

@narrenfrei narrenfrei commented Apr 13, 2021

As already discussed in #342 this is my suggestion for a foldable sidebar menu. It should also work with a cached sidebar menu. I've also added some general CSS tweaks for the sidebar menu.

Here you can find a preview (that also have set icons in the sidebar menu partly): https://deploy-preview-518--docsydocs.netlify.app/docs/

I've also added a short how to: https://deploy-preview-518--docsydocs.netlify.app/docs/adding-content/navigation/#section-menu

This PR is based on the PR #511 (manual extern links) and should merged after it.

@google-cla
Copy link
Copy Markdown

google-cla bot commented May 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@narrenfrei
Copy link
Copy Markdown
Contributor Author

@LisaFC After bringing my dev branch up to date with the current master from Docsy, the cla/google bot says: "CLAs are signed, but unable to verify author consent". I don't really know why? Do you (or anybody else) know why, and more important how to solve it?

@narrenfrei
Copy link
Copy Markdown
Contributor Author

FYI: the PR also includes a few minor changes, as the sidebar menu was a bit wasteful with space (every UL tag got a padding right - also the nested ones!).

@google-cla
Copy link
Copy Markdown

google-cla bot commented May 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@narrenfrei
Copy link
Copy Markdown
Contributor Author

From my side this PR would be ready (except some code cleaning and polishing).

Would be grateful for feedback or if someone would find time to test:
https://deploy-preview-518--docsydocs.netlify.app/docs/

@google-cla
Copy link
Copy Markdown

google-cla bot commented May 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@LisaFC
Copy link
Copy Markdown
Collaborator

LisaFC commented May 18, 2021

@emckean, do you know what's going on with the Google CLA bot?

I'll take some time later today/tomorrow to have a look at the actual functionality in the PR! Thanks for this!

@google-cla
Copy link
Copy Markdown

google-cla bot commented May 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@narrenfrei narrenfrei changed the title WIP: Foldable sidebar (Issue #342) Foldable sidebar (Issue #342) May 29, 2021
@google-cla
Copy link
Copy Markdown

google-cla bot commented May 29, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@narrenfrei
Copy link
Copy Markdown
Contributor Author

As the PR is ready from my side, I've removed the WIP in the label.

When merging you should exclude:

config.toml
userguide/content/blog
userguide/content/en/docs/dev-test-content

@narrenfrei
Copy link
Copy Markdown
Contributor Author

Would be great, if we could get this merged soon.
The Problem with the google-cla bot should be the same as in #554

@RichieEscarez RichieEscarez added the cla: yes Indicates the PR's author has signed the CLA. label Jun 11, 2021
@narrenfrei
Copy link
Copy Markdown
Contributor Author

@LisaFC Shall I remove my test content from the PR, that you can simply merge it?

@RichieEscarez
Copy link
Copy Markdown
Contributor

I think I resolved the "merge conflicts" that were blocking this PR (do take a look to validate) but I'll let @LisaFC handle the final review/merging of the content.

@LisaFC
Copy link
Copy Markdown
Collaborator

LisaFC commented Jun 14, 2021

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants