WIP - taxonomy support #272 #324#539
WIP - taxonomy support #272 #324#539narrenfrei wants to merge 48 commits intogoogle:masterfrom narrenfrei:dev-taxonomy
Conversation
See comments of gwatts. I tested in locally and deployed it for tests under https://tangly-team.bitbucket.io/. The blog part of the site has tags. The pull request is based on your comment in the review. I hope it helps the progress of your feature. It is really cool.
See comments of gwatts. I tested in locally and deployed it for tests under https://tangly-team.bitbucket.io/. The blog part of the site has tags. The pull request is based on your comment in the review. I hope it helps the progress of your feature. It is really cool.
Update script as described in the review comments
Update tags.html
It was recommended that this be updated for this to build with netlify, attempting to do so.
See comments of gwatts. I tested in locally and deployed it for tests under https://tangly-team.bitbucket.io/. The blog part of the site has tags. The pull request is based on your comment in the review. I hope it helps the progress of your feature. It is really cool.
See comments of gwatts. I tested in locally and deployed it for tests under https://tangly-team.bitbucket.io/. The blog part of the site has tags. The pull request is based on your comment in the review. I hope it helps the progress of your feature. It is really cool.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@LisaFC After I had created the PR, I recognized (because of the google-cla bot) that we now have to resign the CLA by all contributors. Shall we wait for their signing or should I make a new PR without the "old" commits as discussed in #324 (comment) ? |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@emckean, what would you suggest here? |
|
Because I've decided to code the taxonomy functionality from scratch, I've closed this PR and made a new PR #554. |
4 participants
As mentioned in #272 and #324 I continued the development of support for taxonomies / tagging.
The current status is only bringing #324 up to date to the current master branch and making a rebase of the already done work.
Some commits for this PR will follow the next days.