[Investigate] Graceful shutdown testing

[aojea]

The driver, once exists, needs to remove the socket so the kubelet can cleanup the orphan resourceslices

Idially we should add an e2e test with bats that just edits the DS to move to 0 replicas, and verify that no resources slices exist

[gmarav05]

hey @aojea i am new to open source can you assign me this issue i just started learning kubernetes i will try to resolve is that okay
if issue is finalized

[aojea]

This requires some previous knowledge of kubernetes, kind, linux ... so just try to evaluate if you are able to tackle this tasks and once you are confident I'll assign it to you

[gmarav05]

This requires some previous knowledge of kubernetes, kind, linux ... so just try to evaluate if you are able to tackle this tasks and once you are confident I'll assign it to you

yeah sure i will try if i can come with some solution

[gmarav05]

hey @aojea please review this

[aojea]

Great, please go ahead and send a PR, replace the sleep with an active loop, you can query it using --wait or other option

[gmarav05]

as requested i have added --wait instead of sleep and sent a PR

[gmarav05]

@gauravkghildiyal can you please review these i have removed teardown and setup

[gauravkghildiyal]

Hi @gmarav05, can you please reopen the same PR and we can start reviewing from there. Were you able to get the local testing working?

[gauravkghildiyal]

While https://github.com/google/dranet/blob/main/tests/README.md should be a good enough resource to help you run the tests, we also have https://github.com/google/dranet/blob/main/DEVELOPER.md for a more general troubleshooting.

[gmarav05]

yeah sure I will reopen the PR and my local tests are failing. I think i have deleted that branch. can I start from scratch? @gauravkghildiyal

[gauravkghildiyal]

It'd be nice if you could push to the same branch to keep context of previous discussion (I think that should be possible). Though if that doesn't work, sure feel free to send in a new PR.