This repository was archived by the owner on May 6, 2026. It is now read-only.
Improve e2e test debugging with got/want logging#135
Merged
Conversation
4223f03 to
b0d2865
Compare
aojea
reviewed
Jun 24, 2025
b0d2865 to
0cfba46
Compare
aojea
reviewed
Jun 24, 2025
0cfba46 to
57c6d16
Compare
aojea
reviewed
Jun 24, 2025
aojea
reviewed
Jun 24, 2025
aojea
approved these changes
Jun 24, 2025
Contributor
aojea
left a comment
There was a problem hiding this comment.
at one point we need to decide if we move everything to git and make this self containerd and more consistent removing the existing github action, but that can be a follow up
https://bats-core.readthedocs.io/en/stable/tutorial.html#quick-installation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's improve test debuggability by logging both the "got" and "want" outputs when a test fails. This follows the best practice outlined in https://bats-core.readthedocs.io/en/stable/faq.html#how-do-i-see-the-output-of-the-command-under-run-when-a-test-fails
Example of test failure: