This repository was archived by the owner on May 6, 2026. It is now read-only.
Fix status updates only adding one device per claim#138
Merged
Conversation
Contributor
Author
|
Tested on kind Previously with dummy0 + dummy1 devices:
- conditions:
- lastTransitionTime: "2025-06-25T17:34:00Z"
message: ""
reason: NetworkDeviceReady
status: "True"
type: Ready
- lastTransitionTime: "2025-06-25T17:34:00Z"
message: ""
reason: NetworkReady
status: "True"
type: NetworkReady
device: dummy1
driver: dra.net
networkData:
hardwareAddress: b6:1b:a9:c1:22:e2
interfaceName: dummy1
ips:
- 169.254.169.14/32
pool: dra-worker
reservedFor:
- name: server-deployment-5f5bfc84cf-xwxgv
resource: pods
uid: dac12658-45e3-44dd-99da-c0991be66673After fix devices:
- conditions:
- lastTransitionTime: "2025-06-25T17:45:20Z"
message: ""
reason: NetworkDeviceReady
status: "True"
type: Ready
- lastTransitionTime: "2025-06-25T17:45:20Z"
message: ""
reason: NetworkReady
status: "True"
type: NetworkReady
device: dummy1
driver: dra.net
networkData:
hardwareAddress: 6e:51:9a:ba:f5:de
interfaceName: dummy1
ips:
- 169.254.169.14/32
pool: dra-worker
- conditions:
- lastTransitionTime: "2025-06-25T17:45:20Z"
message: ""
reason: NetworkDeviceReady
status: "True"
type: Ready
- lastTransitionTime: "2025-06-25T17:45:20Z"
message: ""
reason: NetworkReady
status: "True"
type: NetworkReady
device: dummy0
driver: dra.net
networkData:
hardwareAddress: 8a:a0:a6:76:e2:18
interfaceName: dummy0
ips:
- 169.254.169.13/32
pool: dra-workerLooks like it is working as expected |
Contributor
|
How hard is adding a bats e2e test to avoid regression? |
Contributor
Author
Shouldn't be too difficult. Let me try it out! |
Member
gauravkghildiyal
left a comment
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Thank you!
Just a few nits
aojea
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to SSA tracking owners, we need to do a batch update of status at the end of our NRI loop. Fix this by tracking all status updates needed and doing a batch update at the end.
Fixes #117