This repository was archived by the owner on May 6, 2026. It is now read-only.
fix: Ignore devices not managed by DraNet in ResourceClaim#154
Merged
Conversation
aojea
approved these changes
Jul 9, 2025
Contributor
aojea
left a comment
There was a problem hiding this comment.
great catch, I thought there was something before like this, or I misremember or at some point I deleted it, but this is really needed
Contributor
|
Ah this is the reason why I had to split my example into 2 separate claims which the pod then asked for. Good fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help enable use cases involving device topology alignment.
Currently, we fail to process ResourceClaims that have devices from distinct drivers like the example below, since we don't recognize the
customgpu0device.