Move DraNet to V1 DRA APIs#172
Conversation
aojea
left a comment
aojea
left a comment
There was a problem hiding this comment.
wait for 1.34 to be released and make the final change just for the GA API avoiding going through v1beta2
|
@michaelasp kubernetes just merged the GA API, this will require a good effort to move examples tests and all these things so feel free to use this PR to perform this migration to GA kubernetes/kubernetes#132706 |
|
@michaelasp my PR kubernetes/kubernetes#133164, bumping dependent api version from v1beta2 to v1 for pcieRoot device attribute helper, is now merged |
Done! Bumped up all the required libraries and seems good, now will just wait for a full release and it should be good to go :) Does it make sense to also use this PR to move all the examples? I can make this a more generic PR then that just moves the APIs to V1 |
I think is a good idea and we can use this PR as the v1 branch that we merge once kube has the first rc candidate on Wednesday 6th August 2025 https://www.kubernetes.dev/resources/release/ |
Sgtm, I wonder if we'll break the KIND tests until a node image is released since the APIs are still unreleased. Let me give it a shot. |
good point, but kind can consume artifacts from upstream , see https://kind.sigs.k8s.io/docs/user/quick-start/#building-images so you can point to the url |
michaelasp
changed the title
|
Looks like this is fully working on V1 apis. I'll create a follow up to move the examples to V1 apis and merge this when 1.34 is released and can move the tests away from pulling a specific node image. |
|
[needs a rebase again, though maybe we want to wait for the rc0 anyhow ...] |
Yeah at this point we tested and it worked, I think we can wait till the rc0 cut |
|
rc0 is Wed 6th of August, @michaelasp can you add yourself a reminder to get this in with rc0 https://www.kubernetes.dev/resources/release/ |
Sure, want me to merge today after I fix rebase issues? I can then fix on the 6th to pin to the RC instead. |
aojea
left a comment
aojea
left a comment
There was a problem hiding this comment.
Kevin (NVIDIA) merged today so it makes sense to get alignment
|
we need to update also the docs that are using v1beta1 in most places |
Yep, my idea was to let this be a code/test change and have a doc change follow up after. |
|
Yep, waiting on the packages to get cut, e.g https://pkg.go.dev/k8s.io/api/core/v1?tab=versions @BenTheElder do you happen to know when those generally get released? |
4 participants
Moves to using V1 apis and standard k8s functions for obtaining the PCIERoot of the network device.
Fixes: #171
cc @everpeace since he added the helper function, this PR is modeled off kubernetes-sigs/dra-driver-nvidia-gpu#429 since it does very similar work. Thanks!