This repository was archived by the owner on May 6, 2026. It is now read-only.
fix: eBPF attribute should be false when there are no programs#192
Merged
Conversation
Currently, eBPF attribute is always set to true since `link.QueryPrograms` mostly returns a successful call. This leads to the program thinking that is has "some" BPF programs since the code does not check for an empty value. This eventually trickles down to failures in "validate bpf filter attributes". The attribute is always true so we never wait and continue checking for the existence of `tcFilterNames` which may not yet have been updated by the driver.
aojea
approved these changes
Aug 15, 2025
Contributor
aojea
left a comment
aojea
left a comment
There was a problem hiding this comment.
Good catch, this library is great but as everything ebpf related it's still relatively new and there are no good examples or docs outside of cilium codebase that explains well the semantics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, eBPF attribute is always set to true since
link.QueryProgramsalways returns as success. This leads to the program thinking that is has "some" BPF programs since the code does not check for an empty return value.This eventually trickles down to failures in "validate bpf filter attributes". The attribute is always true so we never wait and continue checking for the existence of
tcFilterNameswhich may not yet have been updated by the driver.Fixes #136