Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

add cleanup functions with debug info on failure between tests#208

Merged
gauravkghildiyal merged 1 commit into
google:mainfrom
aman0408:make-tests-independent
Aug 27, 2025
Merged

add cleanup functions with debug info on failure between tests#208
gauravkghildiyal merged 1 commit into
google:mainfrom
aman0408:make-tests-independent

Conversation

@aman0408
Copy link
Copy Markdown
Contributor

@aman0408 aman0408 commented Aug 25, 2025

  • Added cleanup between tests
  • Reduced kubectl wait timeout from 300 to 120 in 2 tests
  • Increased BATS_TEST_TIMEOUT from 120 to 150
  • Fixes part of Organize the e2e tests #137

@gauravkghildiyal gauravkghildiyal self-requested a review August 25, 2025 22:20
@aman0408 aman0408 marked this pull request as ready for review August 26, 2025 18:27
Copy link
Copy Markdown
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aman0408 . Just a few suggestions.

Also, let's squash commits (makes sense here maybe?) and remove the merge commit.

Comment thread tests/e2e.bats
Comment thread tests/e2e.bats Outdated
Comment thread tests/setup_suite.bash Outdated
Comment thread tests/e2e.bats
@gauravkghildiyal gauravkghildiyal changed the title Make e2e tests independent of each other add cleanup functions with debug info on failure between tests Aug 27, 2025
Copy link
Copy Markdown
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread tests/e2e.bats
Copy link
Copy Markdown
Contributor

@michaelasp michaelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, only a minor comment that can be delegated to a new issue.

@gauravkghildiyal gauravkghildiyal merged commit 224f268 into google:main Aug 27, 2025
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants