This repository was archived by the owner on May 6, 2026. It is now read-only.
feat: Add IPAlias GCE Attribute to published resourceslices#215
Merged
gauravkghildiyal merged 2 commits intoAug 28, 2025
Conversation
gauravkghildiyal
force-pushed
the
gce-alias-attribute
branch
2 times, most recently
from
f48b0ac to
79379e9
Compare
gauravkghildiyal
force-pushed
the
gce-alias-attribute
branch
from
79379e9 to
48bf0c0
Compare
Contributor
|
any use case for this? I think is ok, but wonder the motivation, or was I already publishing them and then we forgot to carry over in a refactor? |
Contributor
|
I see, but this is only publishing the information ... should we also get the aliases from the interface we discover on the host? should we also move them and allow to set them via the opaque config ? |
Member
Author
|
This wasn't getting published before, so net new. The only motivation is ability to be able to exclude network interfaces with this IP Alias configured. |
michaelasp
reviewed
Aug 28, 2025
aojea
approved these changes
Aug 28, 2025
Contributor
SGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.