Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

Add lastPublishedTime metric in PublishResources and relevant test#236

Merged
gauravkghildiyal merged 1 commit into
google:mainfrom
aman0408:add-lastPublishedTime-metric
Sep 17, 2025
Merged

Add lastPublishedTime metric in PublishResources and relevant test#236
gauravkghildiyal merged 1 commit into
google:mainfrom
aman0408:add-lastPublishedTime-metric

Conversation

@aman0408
Copy link
Copy Markdown
Contributor

  • Add lastPublishedTime metric in PublishResources and relevant test
  • Restructure objects to interfaces for better testability

Copy link
Copy Markdown
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Looks good.

Comment thread pkg/driver/dra_hooks_test.go Outdated
Comment thread pkg/driver/dra_hooks_test.go Outdated
Comment thread pkg/driver/driver.go
Comment thread pkg/driver/driver.go Outdated
Comment thread pkg/driver/driver.go Outdated
Comment thread pkg/driver/dra_hooks_test.go Outdated
…estructure objects to interfaces for better testability.
@aman0408 aman0408 marked this pull request as ready for review September 17, 2025 20:20
@gauravkghildiyal gauravkghildiyal merged commit 1a2219f into google:main Sep 17, 2025
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants