This repository was archived by the owner on May 6, 2026. It is now read-only.
refactor: Parse cloud instance topology only once#261
Merged
Conversation
gauravkghildiyal
force-pushed
the
parse-topology-once
branch
from
518cfb6 to
8975fba
Compare
aojea
reviewed
Oct 15, 2025
aojea
reviewed
Oct 15, 2025
aojea
reviewed
Oct 15, 2025
aojea
previously requested changes
Oct 15, 2025
Contributor
aojea
left a comment
aojea
left a comment
There was a problem hiding this comment.
This looks premature to me, just fix the logging problem , we should only log the real parsing errors , not the ones because the node does not have topology
Contributor
|
just fix the logging problem to not error if is empty and we'll iterate later |
gauravkghildiyal
force-pushed
the
parse-topology-once
branch
from
8975fba to
c7919e0
Compare
This also helps avoid unnecessary logging that happens each time we need to reconstruct ResourceSlice state and it's cloud provider attributes.
gauravkghildiyal
force-pushed
the
parse-topology-once
branch
from
c7919e0 to
630e359
Compare
Member
Author
|
Thanks for the feedback. Incorporated. |
gauravkghildiyal
force-pushed
the
parse-topology-once
branch
from
c7d8b94 to
630e359
Compare
aojea
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the topology string was stored in the CloudInstance struct and parsed every time GetGCEAttributes was called. This reparsing is not required and also resulted in excessive logs for "Error parsing host topology"