This repository was archived by the owner on May 6, 2026. It is now read-only.
Split apart cloudNetwork device attribute#83
Merged
Conversation
gauravkghildiyal
requested review from
gauravkghildiyal
and removed request for
aojea
aojea
reviewed
May 22, 2025
aojea
reviewed
May 22, 2025
aojea
reviewed
May 22, 2025
liuyuan10
reviewed
May 22, 2025
aojea
reviewed
May 23, 2025
aojea
reviewed
May 25, 2025
liuyuan10
reviewed
May 25, 2025
Member
gauravkghildiyal
left a comment
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Thanks for the PR @ngcxy ! This is great to start with.
I've made a few comments. As you become more familiar with these things, these will get more natural to you.
Contributor
|
overal LGTM. @gauravkghildiyal for final decision, ping me for merging |
The initial attribute of "cloudNetwork" contains a string with both the network name and the project number, which may exceed the limitation of attribute size. This commit splits the "cloudNetwork" into two parts, as well as introduces provider-specific function to manage the attributes.
gauravkghildiyal
approved these changes
May 28, 2025
Member
gauravkghildiyal
left a comment
gauravkghildiyal
left a comment
There was a problem hiding this comment.
LGTM.
Ready to merge @aojea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve attribute readability for cloud network and flexibility for cloud provider.
This is a draft PR that only contains the key logic, without comprehensive case handling.