-
Notifications
You must be signed in to change notification settings - Fork 40
Use bzlmod #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bzlmod #64
Conversation
Use the new Bazel module system. This should hopefully help fix the broken re2 import in SPIRV-Tools.
|
@dneto0 for review |
dneto0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
dneto0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like kokoro/scripts/linux/build-docker.sh needs to request bazel-7.0.2 instead of 5
Head branch was pushed to by a user without write access
|
@dneto0 I've updated the PR to use the correct Bazel version in Kokoro. I think the |
dneto0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and thanks for your patienc.
|
Heh. a failure: Looking at that PR, this seems like the useful advice: bazel-contrib/rules_python#713 (comment) Which exercises the I started looking at the examples for rules_python. Starting from the docs at https://github.com/bazelbuild/rules_python/blob/main/BZLMOD_SUPPORT.md |
| dev_dependency = True, | ||
| ) | ||
|
|
||
| bazel_dep(name = "re2", version = "2024-04-01") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we need:
bazel_dep(name = "rules_python", version = "0.31.0")
python = use_extension("@rules_python//python/extensions:python.bzl", "python")
python.toolchain(
configure_coverage_tool = False,
ignore_root_user_error = True,
python_version = "3.11",
)
I think that's all the necessary pieces?
Head branch was pushed to by a user without write access
Use the new Bazel module system. This should hopefully help fix the broken re2 import in SPIRV-Tools.