Skip to content

Fix incorrect padding in arrays of structs (Issue #5484)#5491

Merged
aardappel merged 1 commit intogoogle:masterfrom
svenk177:fix-array-struct-alignment
Aug 23, 2019
Merged

Fix incorrect padding in arrays of structs (Issue #5484)#5491
aardappel merged 1 commit intogoogle:masterfrom
svenk177:fix-array-struct-alignment

Conversation

@svenk177
Copy link
Copy Markdown
Contributor

This PR fixes issue #5484 and adds additional tests for alignment.

@svenk177 svenk177 force-pushed the fix-array-struct-alignment branch 2 times, most recently from 0e43607 to 2cc087e Compare August 22, 2019 07:29
@aardappel
Copy link
Copy Markdown
Collaborator

Thanks for the fix!
I appreciate the extra tests, but if adding new structs like that is generating lots of new files as you can see. Can you instead change the existing structs to improve coverage of this feature?

@svenk177 svenk177 force-pushed the fix-array-struct-alignment branch from 2cc087e to e6753bb Compare August 23, 2019 06:54
@svenk177 svenk177 force-pushed the fix-array-struct-alignment branch from e6753bb to 0947679 Compare August 23, 2019 06:57
@svenk177
Copy link
Copy Markdown
Contributor Author

Moved it into the existing structs.

@aardappel
Copy link
Copy Markdown
Collaborator

Thanks, that looks great :)

@aardappel aardappel merged commit 4525c91 into google:master Aug 23, 2019
@svenk177 svenk177 mentioned this pull request Sep 5, 2019
LuckyRu pushed a commit to LuckyRu/flatbuffers that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants