Fix Mutate() methods of Array<scalar/struct> (override 5508)#5526
Merged
aardappel merged 4 commits intogoogle:masterfrom Sep 23, 2019
Merged
Fix Mutate() methods of Array<scalar/struct> (override 5508)#5526aardappel merged 4 commits intogoogle:masterfrom
aardappel merged 4 commits intogoogle:masterfrom
Conversation
…e#5508) - Tag dispatching is used for implicit specialization - Array<scalar> and Array<struct> have different iterators and accessors - Array<scalar> and Array<struct> have different Mutate() methods
svenk177
reviewed
Sep 23, 2019
Contributor
svenk177
left a comment
svenk177
left a comment
There was a problem hiding this comment.
This looks great 👍
Tested it with VS2017.
…e#5508) - Tag dispatching is used for implicit specialization - Array<scalar> and Array<struct> have different iterators and accessors - Array<scalar> and Array<struct> have different Mutate() methods
Collaborator
|
Thanks for putting it together, @vglavnyy ! |
LuckyRu
pushed a commit
to LuckyRu/flatbuffers
that referenced
this pull request
Oct 2, 2020
…5526) * Draft with Array specialization (google#5508) * Array specialization + SFINAE to fold copy-paste (google#5508) * Add implicit specialization of Array<scalar> and Array<struct> (google#5508) - Tag dispatching is used for implicit specialization - Array<scalar> and Array<struct> have different iterators and accessors - Array<scalar> and Array<struct> have different Mutate() methods * Add implicit specialization of Array<scalar> and Array<struct> (google#5508) - Tag dispatching is used for implicit specialization - Array<scalar> and Array<struct> have different iterators and accessors - Array<scalar> and Array<struct> have different Mutate() methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overrides #5508.
@svenk177 could you review changes?