Add default to offset param of Python generated GetRootAs#6312
Merged
aardappel merged 1 commit intogoogle:masterfrom Dec 7, 2020
Merged
Add default to offset param of Python generated GetRootAs#6312aardappel merged 1 commit intogoogle:masterfrom
aardappel merged 1 commit intogoogle:masterfrom
Conversation
Collaborator
|
The downside is that users may not be aware there is such an argument, when dealing with buffers that were just constructed locally and may not start at 0. But yet, when receiving these from file or network it is likely 0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like the most common case for this parameter so why not make it even easier.