[CPP] Formats cpp files with clang-format #6349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c#
c++
codegen
mustiikhalil
force-pushed
the
cpp-formatting
branch
2 times, most recently
from
b6e45f6 to
846d833
Compare
mustiikhalil
commented
Dec 22, 2020
Collaborator
|
Might cause merge difficulties for src/idl_gen_js_ts.cpp and ongoing work in #6302, can we postpone this cleanup for that file? |
Collaborator
Author
|
Definitely, whenever #6302 gets merged i will reformat it and push, then we can merge it |
Collaborator
Author
|
should revisit this after #6375 gets merged |
mustiikhalil
force-pushed
the
cpp-formatting
branch
from
ac8062b to
e2b8a70
Compare
Collaborator
|
Still a draft? |
Collaborator
Author
|
Yeah, waiting for #6302 to get merged |
mustiikhalil
force-pushed
the
cpp-formatting
branch
from
e2b8a70 to
796ed68
Compare
github-actions
bot
added
c++
codegen
mustiikhalil
force-pushed
the
cpp-formatting
branch
from
e18199c to
4e5e1e7
Compare
Collaborator
Author
|
@aardappel should be ready now :D |
Collaborator
|
@mustiikhalil sadly I think @CasperN beat you to it! You can rebase and then merge. |
mustiikhalil
force-pushed
the
cpp-formatting
branch
from
4e5e1e7 to
3c32f1c
Compare
mustiikhalil
force-pushed
the
cpp-formatting
branch
from
3c32f1c to
673222b
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formats the cpp files with
clang-formatsince some of the files were not formatted properly Closes #6343