Default strings and vectors: Parser + Rust support#6421
Default strings and vectors: Parser + Rust support#6421CasperN merged 12 commits intogoogle:masterfrom
Conversation
|
Please rebase. |
|
Rebased and added more tests. @aardappel, PTAL again |
aardappel
left a comment
There was a problem hiding this comment.
This generally looks good! Though not sure if this should go in without at least 1 language that uses this data.. I understand you're wanting to keep commits small, but it also has value to see new data actually used.
|
Can you undo the unrelated clang-format changes? Are you using our script, or at least |
|
This looks great.. ready to merge, unless you want anyone else to review it. |
|
@krojew, can I also get your review? |
|
@CasperN using flatbuffers::Parser;
TEST_EQ(false, Parser().Parse("enum e:e{}table T{p:[e]=[]"));with assertion:
Could you take a look at this problem? |
|
Should probably be fixed before #6353 |
|
dang it, I made the same mistake while doing optional scalars 🙄 |
First steps towards #6053:
This should go in after #6420