You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The alloc check binaries use a global non-thread-safe allocation counter (static mut NUM_ALLOCS) to assert zero heap allocations on warm builder reuse.
When run via cargo test, the test harness's background threads occasionally allocate, inflating the counter and causing intermittent assertion failures. These binaries are already run reliably via cargo run --bin in RustTest.sh, so disabling them as test targets avoids the flaky behavior with no loss of coverage. Closes#8961
Just to make sure I understand your comment, these tests are executed as part of a PR build elsewhere? What is the use of this file?
RustTest.sh runs two commands that both execute flexbuffers_alloc_check:
Line 46:cargo test -- --quiet — This runs all test targets in the package, including any [[bin]] with #[test] functions. It picks up flexbuffers_alloc_check because it has a #[test] fn no_extra_allocations().
Line 55:cargo run --bin=flexbuffers_alloc_check — This runs the same binary directly via its main() function, without the test harness.
So the same binary was being executed twice in a single CI run — first by cargo test (with the test harness, which adds background threads and extra allocations), then by cargo run --bin (clean, no harness). The flaky failure happens in step 1 because the test harness threads' allocations interfere with the global counter.
With test = false, cargo test skips these binaries entirely, and they only run via the reliable cargo run --bin path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alloc check binaries use a global non-thread-safe allocation counter (static mut NUM_ALLOCS) to assert zero heap allocations on warm builder reuse.
When run via
cargo test, the test harness's background threads occasionally allocate, inflating the counter and causing intermittent assertion failures. These binaries are already run reliably viacargo run --binin RustTest.sh, so disabling them as test targets avoids the flaky behavior with no loss of coverage.Closes #8961