Fix infinite loop / OOM in proto reserved range parser#8966
Merged
jtdavis777 merged 2 commits intoMar 12, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
Hi, I'm a big fan of google and I'm going to contribute here actively, as a contributor. |
jtdavis777
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8949
Summary
Fixes infinite loop and OOM when parsing proto
reservedranges that include the maximum field ID (65535). Addresses issue #8949.Root cause
The loop in
idl_parser.cpp(parsing e.g.reserved 0 to 65535) usedvoffset_t(uint16_t) as the loop counter. Whenidreached 65535,id++wrapped to 0, so the conditionid <= attributeremained true and the loop never exited, causing unbounded memory growth (CWE-835, CWE-400).Fix
Use
uint32_tfor the loop counter so that after the last valid value (65535),idbecomes 65536 and the loop terminates. Values are cast tovoffset_tonly when appending toreserved_ids.