[Swift] Migrate to swift 6.0 and Implements support gRPC v2#8983
Conversation
github-actions
Bot
added
python
c++
grpc
codegen
mustiikhalil
force-pushed
the
mmk/grpc-swift-2
branch
from
e9418c9 to
4f1c2a2
Compare
mustiikhalil
force-pushed
the
mmk/grpc-swift-2
branch
from
4f1c2a2 to
10c42be
Compare
mustiikhalil
changed the title
mustiikhalil
force-pushed
the
mmk/grpc-swift-2
branch
2 times, most recently
from
ede0775 to
39fccbf
Compare
|
Is there much/any danger of causing compatibility breaks with this change? Will swift users be forced to update? |
Yes, users will be forced to update to swift 6.0. However that would only be for upcoming flatbuffers releases, and flatbuffers swift has been stable for a while now. Usually I follow the swift-protobuf repository when it comes to supported swift versions. Currently the minimum there is |
mustiikhalil
force-pushed
the
mmk/grpc-swift-2
branch
from
39fccbf to
f997a6e
Compare
|
@hassila if you got time, a second eye on the swift code would be nice! I did force @unchecked sendable for now. but we can revisit that after the PR is merged and after understanding how flatbuffers would work with concurrency |
blindspotbounty
left a comment
blindspotbounty
left a comment
There was a problem hiding this comment.
I looked only at flatbuffers which looks good to me.
Unfortunately, I don't know much of grpc specifics..
mustiikhalil
force-pushed
the
mmk/grpc-swift-2
branch
from
e4c4bd3 to
918f388
Compare
jtdavis777
left a comment
jtdavis777
left a comment
There was a problem hiding this comment.
The generator code looks alright when compared to the previous structure of this file -- there are some things to be improved (see the comments) but want your take on if you want to take on such a project at this time. I'd rather see the new feature than gate this on trying to improve it.
Let's have some discussion on my comments about it then I will approve
The following migrates to swift 6.0, and also migrate to swift-grpc 2.0 that uses swift-nio under the hood to provide nicer API and async await Adds sendable to enum & update @_implementationOnly imports to use internal imports
mustiikhalil
force-pushed
the
mmk/grpc-swift-2
branch
from
918f388 to
dd36b4a
Compare
|
@mustiikhalil looks like you have one unresolved comment - feel free to resolve and merge when ready! |
|
@jtdavis777 thanks for the review again! |
5 participants
The following PR migrate the support for the swift library to swift 6.0, since that's the minimum version we can use for
swift gRPC 2.0which uses async/await under the hood. It would also enable us to migrate away from XCTests into swift testing in a future PR.