Skip to content

Fix indention level for --no-python-gen-numpy#9049

Merged
jtdavis777 merged 1 commit into
google:masterfrom
fliiiix:bugfix/indent-no-numpy
Apr 17, 2026
Merged

Fix indention level for --no-python-gen-numpy#9049
jtdavis777 merged 1 commit into
google:masterfrom
fliiiix:bugfix/indent-no-numpy

Conversation

@fliiiix
Copy link
Copy Markdown
Contributor

@fliiiix fliiiix commented Apr 17, 2026

Indention level is wrong. See minimal reproducer example:

monster_extra.fbs

table MonsterExtra {
  dvec : [double];
}

Generate with ./flatc --python --no-python-gen-numpy --gen-object-api monster_extra.fbs

without the fix

# MonsterExtraT
    def Pack(self, builder):
        if self.dvec is not None:
            MonsterExtraStartDvecVector(builder, len(self.dvec))
            for i in reversed(range(len(self.dvec))):
                builder.PrependFloat64(self.dvec[i])
                dvec = builder.EndVector()
        MonsterExtraStart(builder)
        if self.dvec is not None:
            MonsterExtraAddDvec(builder, dvec)
        monsterExtra = MonsterExtraEnd(builder)
        return monsterExtra

note the dvec = builder.EndVector() inside the loop

And with the fix ->

    # MonsterExtraT
    def Pack(self, builder):
        if self.dvec is not None:
            MonsterExtraStartDvecVector(builder, len(self.dvec))
            for i in reversed(range(len(self.dvec))):
                builder.PrependFloat64(self.dvec[i])
            dvec = builder.EndVector()
        MonsterExtraStart(builder)
        if self.dvec is not None:
            MonsterExtraAddDvec(builder, dvec)
        monsterExtra = MonsterExtraEnd(builder)
        return monsterExtra

@fliiiix fliiiix requested a review from dbaileychess as a code owner April 17, 2026 16:21
@github-actions github-actions Bot added python c++ codegen Involving generating code from schema labels Apr 17, 2026
@fliiiix
Copy link
Copy Markdown
Contributor Author

fliiiix commented Apr 17, 2026

//cc @jtdavis777 an other small fix easy to merge

@jtdavis777 jtdavis777 merged commit d6444fb into google:master Apr 17, 2026
51 checks passed
@fliiiix fliiiix deleted the bugfix/indent-no-numpy branch April 18, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ codegen Involving generating code from schema python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants