-
Notifications
You must be signed in to change notification settings - Fork 297
Add support for branch coverage #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonathanmetzman
merged 15 commits into
google:master
from
Practical-Formal-Methods:master
Jun 7, 2022
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fcf3de3
instroduce branch coverage metric for llvm source-based coverage
jiradeto d93a093
Merge pull request #1 from Practical-Formal-Methods/use_branch_coverage
jiradeto ae075ce
add pylint: disable=too-many-arguments
jiradeto 1d4f8ae
use single quote and update argument description
jiradeto 59b1877
Merge branch 'master' of https://github.com/google/fuzzbench
jiradeto 5d661dc
use branch coverage as default and fix test
jiradeto eef9835
format code
jiradeto 1ea34be
format code
jiradeto ba96e06
change unique covered regions to unique covered branches
jiradeto a072ff9
Merge branch 'master' of https://github.com/google/fuzzbench
jiradeto c2ac027
remove comment
jiradeto a9eb435
add final newline
jiradeto 1b83e2c
address pull request feedbacks
jiradeto f241a34
set region coverage as an optional coverage metric
jiradeto 56f1f99
Merge branch 'master' of https://github.com/google/fuzzbench
jiradeto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bit of an issue I need to figure out wrt to merging this.
If people are in the middle of writing papers, they cant split their experiments between Fuzzbench-region and Fuzzbench-branch. Need to think about how to handle this.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! changing from region to branch coverage surely causes trouble to people who want to rerun the experiment. This is kind of a breaking change IMO. I believe we should perhaps make it optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathanmetzman Couldn't those people simply use an older version of fuzzbench (with region coverage) if they really don't want branch coverage? While I agree that this is sort of a breaking change it should not invalidate existing research results, correct?
Perhaps we could confirm the above by comparing two evalations (one with region coverage and one with branch coverage) before merging this. What do you think?