Skip to content

Fix failing integration test for measuring coverage #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanmetzman merged 1 commit into from
Jun 8, 2022
Merged

Fix failing integration test for measuring coverage #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified experiment/measurer/test_data/llvm_tools/llvm-cov
View file
Open in desktop
Binary file not shown.
Binary file modified experiment/measurer/test_data/llvm_tools/llvm-profdata
View file
Open in desktop
Binary file not shown.
Binary file modified experiment/measurer/test_data/test_measure_snapshot_coverage/freetype2-2017-coverage
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions experiment/measurer/test_measure_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def test_measure_snapshot_coverage( # pylint: disable=too-many-locals
# fakefs. A directory containing necessary llvm tools is also added to
# PATH.
llvm_tools_path = get_test_data_path('llvm_tools')
os.environ["PATH"] += os.pathsep + llvm_tools_path
os.environ['PATH'] += os.pathsep + llvm_tools_path
os.environ['WORK'] = str(tmp_path)
mocked_is_cycle_unchanged.return_value = False
# Set up the coverage binary.
Expand Down Expand Up @@ -423,7 +423,7 @@ def test_measure_snapshot_coverage( # pylint: disable=too-many-locals
snapshot_measurer.trial_num, cycle, False)
assert snapshot
assert snapshot.time == cycle * experiment_utils.get_snapshot_seconds()
assert snapshot.edges_covered == 13178
assert snapshot.edges_covered == 4629


@pytest.mark.parametrize('archive_name',
Expand Down