Skip to content

Add support for storing basic block context in Gematria formats.#288

Open
virajbshah wants to merge 3 commits intogoogle:experiment/preceding-following-contextfrom
virajbshah:block-context-storage
Open

Add support for storing basic block context in Gematria formats.#288
virajbshah wants to merge 3 commits intogoogle:experiment/preceding-following-contextfrom
virajbshah:block-context-storage

Conversation

@virajbshah
Copy link
Copy Markdown
Contributor

@virajbshah virajbshah commented Jan 19, 2025

  • Add fields to the proto specification to store context.
  • Add members to the Gematria BasicBlock data structure to store context and update methods on it and its Python binding accordingly.
  • Bonus: Remove dangling TODO.

@virajbshah
Add support for storing basic block context in Gematria formats.
c0da27c 
 * Add fields to the `proto` specification to store context.
 * Add members to the Gematria `BasicBlock` data structure to store
   context and update methods on it and its Python binding accordingly.
 * Bonus: Remove dangling TODO.
@virajbshah
Copy link
Copy Markdown
Contributor Author

virajbshah commented Jan 19, 2025

Bumping the C++ formatting CI version from v4.11.0 (clang-format-16) -> v4.14.0 (clang-format-19) should be enough to fix that failing check, though I'm not sure if re-running it after the update will use the new version without adding another commit to this PR.

boomanaiden154 added a commit to boomanaiden154/gematria that referenced this pull request Jan 29, 2025
@boomanaiden154
Bump clang-format version to v19
35409df 
This patch bumps the clang-format that we are using to v19 to fix some
issues that came up in google#288.
@boomanaiden154 boomanaiden154 mentioned this pull request Jan 29, 2025
Merged
boomanaiden154 added a commit to boomanaiden154/gematria that referenced this pull request Jan 29, 2025
@boomanaiden154
Bump clang-format version to v19
e159a21 
This patch bumps the clang-format that we are using to v19 to fix some
issues that came up in google#288.
@boomanaiden154
Copy link
Copy Markdown
Collaborator

boomanaiden154 commented Jan 29, 2025

though I'm not sure if re-running it after the update will use the new version without adding another commit to this PR.

#291. If you rerun the checks, it will be fixed. Github tests PRs as if they are merged against main by default.

boomanaiden154
boomanaiden154 reviewed Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

Comment thread gematria/proto/basic_block.proto Outdated
Comment thread gematria/basic_block/basic_block.cc Outdated
boomanaiden154 added a commit that referenced this pull request Jan 29, 2025
@boomanaiden154
Bump clang-format version to v19 (#291)
d654ace 
This patch bumps the clang-format that we are using to v19 to fix some
issues that came up in #288.
@virajbshah
Copy link
Copy Markdown
Contributor Author

virajbshah commented Jan 30, 2025

If you rerun the checks, it will be fixed. Github tests PRs as if they are merged against main by default.

That would make sense, but for whatever reason re-running the action still uses clang-format-18. IIRC, adding another commit to the PR is what gets GitHub to pick up on the updated workflows.

@boomanaiden154
Copy link
Copy Markdown
Collaborator

boomanaiden154 commented Jan 30, 2025

That would make sense, but for whatever reason re-running the action still uses clang-format-18. IIRC, adding another commit to the PR is what gets GitHub to pick up on the updated workflows.

Interesting. Running git merge main on your branch after pulling a recent main should definitely fix the issue.

ondrasej
ondrasej requested changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ondrasej ondrasej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good. I'll approve once the comments are all resolved.

Comment thread gematria/basic_block/basic_block.cc Outdated
Comment thread gematria/proto/basic_block.proto Outdated
Comment thread gematria/proto/basic_block.proto Outdated
Comment thread gematria/proto/basic_block.proto Outdated
Comment thread gematria/proto/basic_block.proto Outdated
ondrasej
ondrasej requested changes Feb 7, 2025
View reviewed changes
Comment thread gematria/proto/basic_block.proto Outdated
@virajbshah
Address reviewer suggestions.
22b2eeb 
 * Change `back_context` -> `preceding_context` and
  `front_context` -> `following_context`.
 * Add test for updated `BasicBlock::ToString`.
 * Keep previous proto field numbering.
@virajbshah virajbshah requested a review from ondrasej February 8, 2025 19:46
@virajbshah virajbshah changed the base branch from main to experiment/preceding-following-context June 9, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrasej ondrasej ondrasej approved these changes

@boomanaiden154 boomanaiden154 boomanaiden154 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@virajbshah @boomanaiden154 @ondrasej