clang34, 35, 36 fails to pass unit tests with C++03

[pshahid]

Hi, I'm getting an error with the signalhandler_unittest with glog 0.3.4 and C++03 with the recent llvm family of compilers.

This is being run on fedora 20, on clang 34, 35, and 36. The following output is from clang35 and 36.

./demangle_unittest  # force to create lt-demangle_unittest
Passed 3 tests

PASS
./src/demangle_unittest.sh
PASS
./signalhandler_unittest  # force to create lt-signalhandler_unittest
OK
./src/signalhandler_unittest.sh
./src/signalhandler_unittest.sh: line 76: 24503 Segmentation fault      GOOGLE_LOG_DIR=. $BINARY segv 2> signalhandler.out1
./src/signalhandler_unittest.sh: line 99: 24510 Terminated              $BINARY loop 2> signalhandler.out2
'SIGFPE' should appear in the output
make[1]: *** [signalhandler_unittest_sh] Error 1

The following output is from clang34 on the same system.

./src/signalhandler_unittest.sh
./src/signalhandler_unittest.sh: line 76: 30842 Segmentation fault      GOOGLE_LOG_DIR=. $BINARY segv 2> signalhandler.out1
./src/signalhandler_unittest.sh: line 99: 30849 Terminated              $BINARY loop 2> signalhandler.out2
./src/signalhandler_unittest.sh: line 113: 30858 Floating point exception$BINARY die_in_thread 2> signalhandler.out3
./src/signalhandler_unittest.sh: line 124: 30865 Aborted                 $BINARY dump_to_stdout > signalhandler.out4
PASS
make[1]: Leaving directory `/my/dir/here/glog/src/glog-0.3.4'
make  check-TESTS
make[1]: Entering directory `/my/dir/here/glog/src/glog-0.3.4'
make[2]: Entering directory `/my/dir/here/glog/src/glog-0.3.4'
PASS: logging_unittest
PASS: demangle_unittest
PASS: stacktrace_unittest
FAIL: symbolize_unittest
PASS: stl_logging_unittest
PASS: utilities_unittest
make[3]: Entering directory `/my/dir/here/glog/src/glog-0.3.4'
make[3]: Leaving directory `/my/dir/here/glog/src/glog-0.3.4'
============================================================================
Testsuite summary for glog 0.3.4
============================================================================
# TOTAL: 6
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
Please report to opensource@google.com
============================================================================
make[2]: *** [test-suite.log] Error 1

Unfortunately I couldn't find test-suite.log to get any error messages out of it. It didn't appear to be created in any of the subdirs from glog-0.3.4.

[pshahid]

I should mention that if I skip the SIGFPE unittest in src while using clang35 or clang36 then I still get a failed unit test for src/symbolize_unittest.

The output is:

Test case TestWithPCInsideNonInlineFunction passed.
Test case TestWithReturnAddress passed.
Check failed: streq("static_func", TrySymbolize((void *)(&static_func)))

[xmnlab]

hey folks! is there any update about that ? I have the same issue here using glog 0.3.5

[xhochy]

The test failure is probably due to configure not finding pthread on your systems. The test code is a no-op when pthread was not found:

glog/src/signalhandler_unittest.cc

Line 92 in 3267f3e

#if defined(HAVE_PTHREAD)