Fixed IsLogFromCurrentProject to include all severities

[Mivekk]

Previously when executing following code LogCleaner would only delete overdue Error log files:

google::EnableLogCleaner(1min);

LOG(ERROR) << "Error hello";
LOG(INFO) << "Info hello";
LOG(WARNING) << "Warning hello";

And if we changed the order to for example:

LOG(INFO) << "Info hello";
LOG(ERROR) << "Error hello";
LOG(WARNING) << "Warning hello";

LogCleaner would only delete overdue Info log files and overdue Error and Warning files were ignored.
To include all severities during LogCleaner's sweep I tested filepath for all severities in a IsLogFromCurrentProject function.

[sergiud]

Thanks for the PR. I have a couple of remarks.

There seem to be build failures caused by the changes.

Please also update the cleaner test cases by adding the corresponding log output.

[sergiud]

You do actually need to modify the string. Something like this should be sufficient:

Suggested change

	cleaned_base_filename.pop_back();
	int dot_pos = cleaned_base_filename.find_last_of('.');
	cleaned_base_filename.erase(dot_pos + 1, std::string::npos);
	const string::size_type dot_pos = cleaned_base_filename.find_last_of('.', cleaned_base_filename.size() - 1);

[sergiud]

Suggested change

	bool found_file = false;
	for (const auto& severity : LogSeverityNames) {
	string cleaned_base_filename_with_severity = cleaned_base_filename + severity;
	```suggestion
	const string base_filename = cleaned_base_filename.substring(0, dot_pos);
	bool found_file = false;
	for (const auto& severity : LogSeverityNames) {
	string cleaned_base_filename_with_severity = base_filename + severity;

[Mivekk]

I'm not sure how I should modify cleaner test cases unfortunately

[sergiud]

You can extend any of the cleanup_*_unittest.cc, for instance, here

glog/src/cleanup_immediately_unittest.cc

Lines 62 to 64 in ac12a9e

	for (unsigned i = 0; i < 1000; ++i) {
	LOG(INFO) << "cleanup test";
	}

by additionally logging at the missing severities.

Please note that the unit tests need to be updated either way because these are failing now with your changes.

[Mivekk]

Updated unit test and all checks should pass now hopefully

[sergiud]

Unfortunately, the cleanup tests are still failing.

[Mivekk]

Fixed an issue different way

[sergiud]

The unit tests are still failing though.

[sergiud]

Closing as abandoned. Please let me know if you want to continue working on this PR.